Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code block on Object Cache Pro page #9405

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix code block on Object Cache Pro page #9405

merged 2 commits into from
Jan 30, 2025

Conversation

jazzsequence
Copy link
Contributor

@jazzsequence jazzsequence commented Jan 30, 2025 •
edited
Loading

I noticed that there was an issue with the code block inside the Note about Lando configuration with OCP. This PR fixes that.

Summary

Enable Object Cache Pro for WordPress - Local configuration with Lando section, specifically

Preview

@jazzsequence
outdent the alert
543c527 
we're no longer in the numbered list so I don't know that we need to be indented here as if we were. this may be what's causing the formatting issue.
@jazzsequence jazzsequence requested a review from a team as a code owner January 30, 2025 17:48
@jazzsequence
Copy link
Contributor Author

My suspicion is that the issue has to do with the nested Alert inside the numbered list. I've removed the indent so the code block is interpreted (more) normally and hoping that does the trick.

@jazzsequence jazzsequence self-assigned this Jan 30, 2025
@jazzsequence jazzsequence added Type: Fix Content Issue or PR to resolve incorrect information in the docs Topic: WordPress WordPress-specific Type: Quick Fix Issues that should be resolvable in a small PR Topic: Caching Caching related issues at the CDN or CMS level labels Jan 30, 2025
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9405-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9405-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@jazzsequence jazzsequence merged commit 9079fb3 into main Jan 30, 2025
12 checks passed
@jazzsequence jazzsequence deleted the fix-code-block-in-ocp-docs branch January 30, 2025 20:05
ccharlton
ccharlton reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@ccharlton ccharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the conditional snippet be more flexible if it was checking simply for 'Not Pantheon Environments' versus sniffing for Lando itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccharlton ccharlton ccharlton left review comments

@rachelwhitton rachelwhitton Awaiting requested review from rachelwhitton

Assignees

@jazzsequence jazzsequence

Labels
Topic: Caching Caching related issues at the CDN or CMS level Topic: WordPress WordPress-specific Type: Fix Content Issue or PR to resolve incorrect information in the docs Type: Quick Fix Issues that should be resolvable in a small PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jazzsequence @ccharlton @rachelwhitton