-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - January 2025 npm updates #9403
base: main
Are you sure you want to change the base?
Conversation
@@ -34,7 +34,7 @@ jobs: | |||
run: | | |||
git fetch origin main | |||
# Check for changed JavaScript files. | |||
CHANGED_FILES=$(git diff --name-only origin/main...HEAD | grep -E '\.js$|\.jsx$|\.ts$|\.tsx$' || echo "") | |||
CHANGED_FILES=$(git diff --name-only --diff-filter=AM origin/main...HEAD | grep -E '\.js$|\.jsx$|\.ts$|\.tsx$' || echo "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jazzsequence @rachelwhitton here's an interesting thing, this workflow failed because it the diff included deleted files (and prettier can't run against a deleted file). So this filter displays only added or modified files.
Deploy is failing which makes me think that the build is failing. |
Looks like the same build error here as PR 9394 - strange since this PR doesn't update the Gus has since fixed this build error over in PR #9394 fyi @stevector
|
This PR updates npm dependencies and removes a bunch of unused variables (clean up that will be mildly helpful when we eventually port this site out of Gatsby)