Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - January 2025 npm updates #9403

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

WIP - January 2025 npm updates #9403

wants to merge 9 commits into from

Conversation

stevector
Copy link
Contributor

@stevector stevector commented Jan 29, 2025

This PR updates npm dependencies and removes a bunch of unused variables (clean up that will be mildly helpful when we eventually port this site out of Gatsby)

@stevector stevector requested a review from a team as a code owner January 29, 2025 23:59
@@ -34,7 +34,7 @@ jobs:
run: |
git fetch origin main
# Check for changed JavaScript files.
CHANGED_FILES=$(git diff --name-only origin/main...HEAD | grep -E '\.js$|\.jsx$|\.ts$|\.tsx$' || echo "")
CHANGED_FILES=$(git diff --name-only --diff-filter=AM origin/main...HEAD | grep -E '\.js$|\.jsx$|\.ts$|\.tsx$' || echo "")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jazzsequence @rachelwhitton here's an interesting thing, this workflow failed because it the diff included deleted files (and prettier can't run against a deleted file). So this filter displays only added or modified files.

@jazzsequence
Copy link
Contributor

Deploy is failing which makes me think that the build is failing.

@rachelwhitton
Copy link
Member

rachelwhitton commented Jan 30, 2025

Looks like the same build error here as PR 9394 - strange since this PR doesn't update the pantheon-systems/pds-toolkit-react package

Gus has since fixed this build error over in PR #9394 fyi @stevector

error Page data from page-data.json for the failed page "/add-site-custom-upstream": {
  "componentChunkName": "component---src-templates-doc-js",
  "path": "/add-site-custom-upstream",
  "result": {
    "data": {
      "doc": {
        "id": "4076cd0b-1f08-5ca6-9960-20a84b82468f",
        "body": "var _excluded = [\"components\"];\nfunction _extends() { return _extends = Object.assign ? Object.assign.bind() : function (n) { for (var e = 1; e < arguments.length; e++) { var t = arguments[e]; for (var r in t) ({}).hasOwnProperty.call(t, r) && (n[...",
        "fields": {
          "slug": "add-site-custom-upstream",
          "editPath": "source/content/add-site-custom-upstream.md"
        },
        "frontmatter": {
          "title": "Create a Site Using a Custom Upstream",
          "image": null,
          "description": "Build a new site using a template.",
          "categories": [
            "migrate"
          ],
          "cms": [
            "wordpress"
          ],
          "contributors": [],
          "featuredcontributor": null,
          "reviewed": "January 01, 2023",
          "showtoc": null,
          "tags": [
            "--"
          ],
          "type": null
        },
        "fileAbsolutePath": "/workspace/source/content/add-site-custom-upstream.md"
      },
      "date": {
        "frontmatter": {
          "reviewed": "2023-01-01T00:00:00.000Z"
        }
      }
    },
    "pageContext": {
      "slug": "add-site-custom-upstream"
    }
  },
  "staticQueryHashes": [
    "1306466170",
    "1324386404",
    "1395367657",
    "2277411425",
    "2865811115",
    "3282600090",
    "3525045572",
    "3544033555",
    "3698701337",
    "4152223115",
    "4248169575",
    "686760142",
    "929718688"
  ]
}
failed Building static HTML for pages - 0.523s
error "window" is not available during Server-Side Rendering. Enable "DEV_SSR" to debug this during "gatsby develop".

  1594 | }, E1 = () => {
  1595 |   const [t, s] = G(
> 1596 |     window.innerWidth !== void 0 ? window.innerWidth : 1024
       | ^
  1597 |   );
  1598 |   return ce(() => {
  1599 |     s(window.innerWidth);


  WebpackError: ReferenceError: window is not defined
  
  - index.js:1596 
    [pantheon-documentation]/[@pantheon-systems]/pds-toolkit-react/_dist/index.j    s:1596:1
  
  - index.js:1611 
    [pantheon-documentation]/[@pantheon-systems]/pds-toolkit-react/_dist/index.j    s:1611:1
  
  - seo.js:184 
    pantheon-documentation/src/layout/seo.js:184:1
  
  - seo.js:192 
    pantheon-documentation/src/layout/seo.js:192:1
  
  - webInfrastructure.js:143 
    pantheon-documentation/src/components/omniSidebarNav/submenus/webInfrastruct    ure.js:143:20
  
  - webInfrastructure.js:139 
    pantheon-documentation/src/components/omniSidebarNav/submenus/webInfrastruct    ure.js:139:9
  
  - about.js:17 
    pantheon-documentation/src/components/omniSidebarNav/submenus/about.js:17:9
  
  - static-entry.js:303 
    pantheon-documentation/.cache/static-entry.js:303:22
  
  - index.js:5 
    pantheon-documentation/src/components/contributorGuest/index.js:5:7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants