-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restructuring terminus install and update instructions #9401
Conversation
|
||
### Self:update not defined | ||
## Installing and Updating Terminus Plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have a section for installing and updating terminus plugins, i would expect terminus self:plugin:update
to be in the documentation, but in this case we just link out to the plugin directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say delete this section from this page, it's already documented on another page.
If the steps were different based on terminus installed via PHAR vs homebrew, then it would be helpful to cover plugin installation/updates in those contexts but otherwise it's just adding noise instead of value I think
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9401-documentation.appa.pantheon.site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this page needed an overall, and removing non-recommended install paths is great.
My only question is on why we moved incompatible systems to be separate from compatible? Not a deal-breaker but seemed a bit odd in the hierarchy to me
Co-authored-by: Chris Reynolds <[email protected]>
Co-authored-by: Chris Reynolds <[email protected]>
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9401-documentation.appa.pantheon.site |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9401-documentation.appa.pantheon.site |
Co-authored-by: Chris Reynolds <[email protected]>
Co-authored-by: Chris Reynolds <[email protected]>
Co-authored-by: Chris Reynolds <[email protected]>
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9401-documentation.appa.pantheon.site |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9401-documentation.appa.pantheon.site |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9401-documentation.appa.pantheon.site |
1 similar comment
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9401-documentation.appa.pantheon.site |
My copy review was very heavy handed so I branched it off in another PR #9406 @stevector @jazzsequence @jms-pantheon can ya'll take a look? Multidev preview: https://multi-8755-documentation.appa.pantheon.site/terminus/install |
* Restructure the restructure * Align headers * Align with updated header * Simpler headers, combine install and update subsections * Linux instead of ubuntu * Combine macos intro copy * Add alert for wls install pre-req * Update source/content/terminus/02-install.md Co-authored-by: Chris Reynolds <[email protected]> * Update source/content/terminus/02-install.md Co-authored-by: Chris Reynolds <[email protected]> --------- Co-authored-by: Chris Reynolds <[email protected]>
Got a 👍 review from @jazzsequence and @jms-pantheon for my copy reviews in #9406 so I merged it here @stevector can you review when convenient? |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9401-documentation.appa.pantheon.site |
Fixes #8755 by restructuring/rewriting https://docs.pantheon.io/terminus/install
I am making this PR while co-working with @jazzsequence. @rachelwhitton can you review? We've mostly copy/pasted existing text into a slightly different ordering of headings. We've also removed references to old installation techniques like apt and composer-managed.