Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Fix twitter cards #9397

Merged
merged 4 commits into from
Jan 28, 2025
Merged

WIP Fix twitter cards #9397

merged 4 commits into from
Jan 28, 2025

Conversation

rachelwhitton
Copy link
Member

@rachelwhitton rachelwhitton commented Jan 28, 2025

Fixes #2419

Summary

Copies the source/images/assets directory to the static/images/assets directory (related Gatsby doc)

Fixes meta image tags across all templates, currently they're 404s, for example:

<meta name="og:image" content="https://docs.pantheon.io/images/assets/default-thumb-doc.png" data-react-helmet="true">
  • Todo: audit all templates to make sure we're using the appropriate image, for example it likely doesn't make sense for the certification template to use a Terminus image
<meta itemprop="image" content="https://docs.pantheon.io/images/assets/terminus-thumbLarge.png" data-react-helmet="true">

@rachelwhitton rachelwhitton requested a review from a team as a code owner January 28, 2025 19:52
@rachelwhitton rachelwhitton changed the title Fix twitter cards WIP Fix twitter cards Jan 28, 2025
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9397-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9397-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9397-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@rachelwhitton rachelwhitton merged commit 1a3c87d into main Jan 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twitter Cards
1 participant