-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional parameters and move behavior into action.yml #18
base: main
Are you sure you want to change the base?
Conversation
Tested releasing with https://github.com/pwtyler/autotag-sandbox/blob/main/.github/workflows/autotag.yml and successful action steps can be found there. |
Realized I still need to update docs... |
Okay, but why? Literally 6 months ago you were telling me we should put shell code into shell scripts rather than GH actions. I'm not opposed but not sure it's necessary? (And if we can shellcheck the shell code, and run parameterized functions in a single |
So Greg and I discussed this a bit last week because I was torn as well— the primary reason was because I was adding the conditionals to each step, and if I wanted all of that in a shell script, I'd be exporting values like That said, as this action.yml file has come together, I could move anything > 3 lines or so into small shell scripts (e.g. the tag step and the push step each their own script). |
lint
CI step.gh-token
(I think this should just work)New input params
v1
) branchv
or notThe input params have been set such that the default behavior matches current behavior— we should determine which, if any, should be flipped as part of released a v1.
TODO