Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change max_length(s) to Reflect Data #69

Merged
merged 9 commits into from
Nov 14, 2014
Merged

Conversation

bllchmbrs
Copy link
Contributor

This is in response to #68.

Pretty small changes that are prepping for #38 .

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling f179239 on anabranch:master into 4177655 on california-civic-data-coalition:master.

@palewire
Copy link
Owner

I'll take a look at this stuff as soon as possible. I've been out of town and need to catch up on a few things today.

@bllchmbrs
Copy link
Contributor Author

@palewire I realize you have a real job. 👍 I'm not going anywhere so no rush on my end. Take care of what you need to - if you want to see my postgres branch I can push to fork to github however it's not quite ready for a pull request yet.

@palewire
Copy link
Owner

Just so I know, where did you pull these updated lengths from?

@bllchmbrs
Copy link
Contributor Author

Guess and check from the data. It would fail telling me the length and I would do a couple above that. They should be within 5-10 of the true longest value in the data of each individual field.

On Thu, Nov 13, 2014 at 5:54 PM, Ben Welsh [email protected]
wrote:

Just so I know, where did you pull these updated lengths from?

Reply to this email directly or view it on GitHub:
#69 (comment)

palewire added a commit that referenced this pull request Nov 14, 2014
Change max_length(s) to Reflect Data
@palewire palewire merged commit d0fc0f5 into palewire:master Nov 14, 2014
@palewire
Copy link
Owner

Okay great. You're in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants