pulsar 3.0.0 - fix unstable tests

ozangunalp · Jun 14, 2023 · 3b0caa0 · 3b0caa0
1 parent 7303602
commit 3b0caa0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/...ging-pulsar/src/test/java/io/smallrye/reactive/messaging/pulsar/fault/PulsarNackTest.java b/...ging-pulsar/src/test/java/io/smallrye/reactive/messaging/pulsar/fault/PulsarNackTest.java
@@ -14,7 +14,6 @@
 import org.apache.pulsar.client.api.Schema;
 import org.apache.pulsar.client.api.SubscriptionInitialPosition;
 import org.eclipse.microprofile.reactive.messaging.Incoming;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import io.smallrye.reactive.messaging.pulsar.PulsarConnector;
@@ -116,12 +115,7 @@ void testReconsumeLater() throws PulsarClientException {
         await().untilAsserted(() -> assertThat(retries).hasSize(20));
     }
 
-    /**
-     * TODO Test Disabled
-     * To be fixed with Pulsar 3.0.0
-     */
     @Test
-    @Disabled
     void testDeadLetterTopic() throws PulsarClientException {
         addBeans(PulsarReconsumeLater.Factory.class);
         // Run app

diff --git a/...va/io/smallrye/reactive/messaging/pulsar/transactions/ExactlyOnceProcessingBatchTest.java b/...va/io/smallrye/reactive/messaging/pulsar/transactions/ExactlyOnceProcessingBatchTest.java
@@ -26,6 +26,7 @@
 import org.eclipse.microprofile.reactive.messaging.Incoming;
 import org.eclipse.microprofile.reactive.messaging.OnOverflow;
 import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
 
@@ -104,8 +105,6 @@ Uni<Void> process(PulsarIncomingBatchMessage<Integer> batch) {
      * There are still duplicate items delivered to the consumer batch after an transaction abort.
      */
     @Test
-    @Disabled
-    @Tag(TestTags.FLAKY)
     void testExactlyOnceProcessorWithProcessingError() throws PulsarAdminException, PulsarClientException {
         addBeans(ConsumerConfig.class);
         this.inTopic = UUID.randomUUID().toString();
@@ -138,7 +137,8 @@ void testExactlyOnceProcessorWithProcessingError() throws PulsarAdminException,
                 .create(), numberOfRecords, (i, producer) -> producer.newMessage().sequenceId(i).value(i).key("k-" + i));
 
         await().untilAsserted(() -> assertThat(app.getProcessed())
-                .containsAll(IntStream.range(0, numberOfRecords).boxed().collect(Collectors.toList())));
+                .containsAll(IntStream.range(0, numberOfRecords).boxed().collect(Collectors.toList()))
+                .doesNotHaveDuplicates());
 
         await().untilAsserted(() -> assertThat(list)
                 .containsAll(IntStream.range(0, numberOfRecords).boxed().collect(Collectors.toList()))