Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Utility::UnixTimeToLargeIntegerFiletime #12030

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DeepDiver1975
Copy link
Member

test in preparation for #12027

Copy link

@CookiePLMonster CookiePLMonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a recommendation - just in case, it might be worth expanding the test to also test for a uint32 overflow that'd theoretically happen on 7 February 2106 at 06:28:15 UTC. An additional test for 28 February 2106 sounds optimal to me.

EDIT:
Also, the expected value you're comparing against in this test seems kind of low - shouldn't it be much higher, considering it's in 100ns units from the year 1600? Seems like the correct result should be 137930652000000000LL:
https://www.wolframalpha.com/input?i=%282148591600+*+10000000%29+%2B+116444736000000000

Is the current value a placeholder?

@DeepDiver1975
Copy link
Member Author

Is the current value a placeholder?

Just a placeholder - I am on Linux and cannot run the test locally. Wanted to see what the LARGE_INTEGER holds 🙈

I need a windows machine .... 🤮

@CookiePLMonster
Copy link

Just a placeholder - I am on Linux and cannot run the test locally. Wanted to see what the LARGE_INTEGER holds 🙈

You can then use the result from WolframAlpha as I linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants