Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pint workflow - Auto fix styling #999

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Jan 23, 2025

Copy link
Contributor

@willpower232 willpower232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't hate linting but what I would rather is that the linting tools were part of composer.json so whoever is working on it can lint before they commit rather than having to pull random lints all the time

@erikn69
Copy link
Contributor Author

erikn69 commented Jan 24, 2025

so whoever is working on it can lint before they commit

Many of those who want to contribute will not have the complete knowledge or might skip it, it is better to leave it automatic, if you check the biggest and more popular packages they have it, I want to avoid extra work for developers or something being overlooked without realizing it.

If you need examples of packages that use them I could mention them.

@parallels999
Copy link
Contributor

parallels999 commented Jan 24, 2025

having to pull random lints all the time

You could add a custom .pint.json, but in my opinion it is better to leave it as is

Laravel Pint is an opinionated PHP code style fixer for minimalists. Pint is built on top of PHP-CS-Fixer and makes it simple to ensure that your code style stays clean and consistent.

laravel/pint/presets/laravel.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants