-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPStal lvl 0 baseline #976
base: master
Are you sure you want to change the base?
Conversation
- ./config | ||
- ./database | ||
- ./src | ||
- ./tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion I don't see the need for tests folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rather analyse everything possible, some type mismatch or other issue can generate incorrect test results.
I think it's better to leave this for v14 align it with v14 laravel-auditing/phpstan.neon.dist Lines 1 to 17 in 595c6cd
|
Up to you, but the v14 hasn't changed for 10 months. I think it's better to chunk it up, move whatever is possible to v13, so things are moving. Also, easier to review smaller PRs |
IMHO it is better to not have a baseline, I would rather just fix the issues and that shouldn't be a problem in a project of this size. I have some time towards the weekend so was planning to make some progress on v14 anyway. |
This can be merged to
v13
as it is only generates a baseline, without actual code change to ensure no more PHPStan level 0 issues are introduced, such as:basic checks, unknown classes, unknown functions, unknown methods called on $this, wrong number of arguments passed to those methods and functions, always undefined variables