-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP Code Standard #975
base: master
Are you sure you want to change the base?
PHP Code Standard #975
Conversation
Thanks for the effort, sounds like its annoyed about the risky setting. Is there a need to have a separate script for ci in this case? |
I prefer to have the CI to just display the issues, instead of fixing them. That could prevent unwanted changes. I will add the risky option in a sec. |
Ah yes I see now, definitely agree with you on that. I don't understand the risky setting but sounds like it would like you to make even more changes 😅 |
In composer I set it to check all folders, while in the original config file, it is looking in only to |
If you merge this, also merge v13 and v14 so that they are synchronized |
The reason it only looks in src is because then it doesn't look in the vendor folder which could be full of all sorts of stuff 😅 |
Fixed |
I have extracted the PHP CS part from the
v14-dev
branch, as this one can be included in v13, the biggest changes are the strict options in some cases.