Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Code Standard #975

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

rajmundtoth0
Copy link

I have extracted the PHP CS part from the v14-dev branch, as this one can be included in v13, the biggest changes are the strict options in some cases.

@willpower232
Copy link
Contributor

Thanks for the effort, sounds like its annoyed about the risky setting. Is there a need to have a separate script for ci in this case?

@rajmundtoth0
Copy link
Author

I prefer to have the CI to just display the issues, instead of fixing them. That could prevent unwanted changes. I will add the risky option in a sec.

@willpower232
Copy link
Contributor

Ah yes I see now, definitely agree with you on that. I don't understand the risky setting but sounds like it would like you to make even more changes 😅

@rajmundtoth0
Copy link
Author

In composer I set it to check all folders, while in the original config file, it is looking in only to /src. Now both checks all folders. Hopefully this makes it happy - also formatted the files outside of /src

@rajmundtoth0
Copy link
Author

@parallels999
Copy link

If you merge this, also merge v13 and v14 so that they are synchronized

@willpower232
Copy link
Contributor

In composer I set it to check all folders, while in the original config file, it is looking in only to /src. Now both checks all folders. Hopefully this makes it happy - also formatted the files outside of /src

The reason it only looks in src is because then it doesn't look in the vendor folder which could be full of all sorts of stuff 😅

@rajmundtoth0
Copy link
Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants