Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql) add prepare: false option and sql``.simple() #17296

Merged
merged 9 commits into from
Feb 14, 2025

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Feb 13, 2025

What does this PR do?

Fix: #17029
Fix: #17044

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Tests

@cirospaciari cirospaciari marked this pull request as draft February 13, 2025 03:08
@robobun
Copy link

robobun commented Feb 13, 2025

Updated 6:17 PM PT - Feb 13th, 2025

@cirospaciari, your commit 0e5f095 has 4 failures in Build #11586:


🧪   try this PR locally:

bunx bun-pr 17296

@cirospaciari cirospaciari marked this pull request as ready for review February 13, 2025 03:34
@Jarred-Sumner
Copy link
Collaborator

are these flaky tests related?
image

@cirospaciari
Copy link
Member Author

cirospaciari commented Feb 13, 2025

are these flaky tests related?
image

Looks like it is due to transaction pooling behavior, need to see what tests are flaky to fix or skip the test
Note: transaction pooling and temporary table tests was a bad combination

@Jarred-Sumner
Copy link
Collaborator

The only part I'm not sure about is if we should make it simple when there are no params.

@Jarred-Sumner Jarred-Sumner merged commit a2c64ad into main Feb 14, 2025
58 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/sql-simple branch February 14, 2025 03:51
@cirospaciari
Copy link
Member Author

The only part I'm not sure about is if we should make it simple when there are no params.

Postgres.js don't make it simple if they have no parameters, but if it's unsafe and has no parameters it's simple, performance is better when it is not a simple query when running the query multiple times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants