Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node:fs: windows: fix integer cast truncating bits when using too large of a mode #17249

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

nektro
Copy link
Member

@nektro nektro commented Feb 11, 2025

fixes #17248

@robobun
Copy link

robobun commented Feb 11, 2025

Updated 9:16 PM PT - Feb 10th, 2025

@nektro, your commit 3a0ecd8 has 7 failures in Build #11425:


🧪   try this PR locally:

bunx bun-pr 17249

@Jarred-Sumner Jarred-Sumner marked this pull request as ready for review February 11, 2025 08:12
@Jarred-Sumner Jarred-Sumner merged commit 251c2b7 into main Feb 11, 2025
54 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the nektro-patch-49423 branch February 11, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash with large mode on windows
3 participants