Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download zig from oven-sh/zig releases & auto set up zls #17128

Merged
merged 3 commits into from
Feb 15, 2025

Conversation

pfgithub
Copy link
Contributor

@pfgithub pfgithub commented Feb 7, 2025

What does this PR do?

Downloads zig from https://github.com/oven-sh/zig/releases automatically

These releases include zls, so updates vscode settings to use zls from vendor/zig/zls.exe in order to not require manual zls setup

Does not require deleting the build folder because the optionx for ZIG_COMMIT is changed to set. optionx will save its default value into the cache after the first run, and not clear it until the cache is deleted.

@robobun
Copy link

robobun commented Feb 7, 2025

Updated 6:25 PM PT - Feb 10th, 2025

@pfgithub, your commit eabf1ba has 4 failures in Build #11402:


🧪   try this PR locally:

bunx bun-pr 17128

@Jarred-Sumner Jarred-Sumner merged commit 3711280 into main Feb 15, 2025
55 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the pfg/zig-download branch February 15, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants