-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sql) support retrieving array values #17094
Open
cirospaciari
wants to merge
20
commits into
main
Choose a base branch
from
ciro/sql-arrays
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+8,098
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated 9:40 PM PT - Feb 5th, 2025
@cirospaciari, your commit 6bdb098 is building: |
cirospaciari
force-pushed
the
ciro/sql-arrays
branch
from
February 6, 2025 02:08
84cd8d3
to
3243d8c
Compare
cirospaciari
force-pushed
the
ciro/sql-arrays
branch
from
February 6, 2025 05:40
1cf6ef8
to
6bdb098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix: #16650
Support for:
Also added support for
oid
,tid
,xid
,cid
and fixdate
types so dates are actually returned as Date objectsKey difference between
Bun.sql
andpostgres.js
is that we always returnnull
when a value isnull
in an array,postgres.js
may return "NULL" string orNaN
,Invalid Date
ornull
depending on the type and if is inside an array or not.Example:
How did you verify your code works?
Tests