[WIP] feat(node:net): node:net compatibility
#17092
Draft
+177
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {T} fn | ||
| * @returns {T} | ||
| */ | ||
| function hideStackFrames(fn) { |
There was a problem hiding this comment.
Set the function name to ::bunternal:: and it will do this automatically
we don't want to add the overhead of calling Error.captureStackTrace in these spots
|
|
||
| if (cluster === undefined) cluster = require("node:cluster"); | ||
| Object.defineProperty(server, "_connectionKey", { |
There was a problem hiding this comment.
If we're going to shim this then we should make sure the enumerable / writable property is set if necessary
| @@ -54,7 +54,7 @@ cluster._setupWorker = function () { | |||
| }; | |||
|
|
|||
| // `obj` is a net#Server or a dgram#Socket object. | |||
| cluster._getServer = function (obj, options, cb) { | |||
| cluster._getServer = function _getServer(obj, options, cb) { | |||
There was a problem hiding this comment.
this will likely become _getServer2 due to the symbol renamer
heimskr
changed the title
node:net compatabilitynode:net compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Very much a wip. Not ready to even be looked at.
How did you verify your code works?