Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable asan on debug macos aarch64 builds #17058

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Enable asan on debug macos aarch64 builds #17058

merged 4 commits into from
Feb 6, 2025

Conversation

pfgithub
Copy link
Contributor

@pfgithub pfgithub commented Feb 5, 2025

What does this PR do?

Problems:

  • Something is wrong with caching because you can't build this branch coming directly from main, you have to delete build first

Usage:

  • Disable with bun run build -DENABLE_ASAN=OFF (must delete build dir)
  • ASAN_OPTIONS=detect_leaks=1 bun-debug abcd
    • not very useful
  • ASAN_OPTIONS=detect_stack_use_after_return=1 bun-debug abcd
    • only works for codepaths which do not use javascript core

Running node tests locally:

  • test-async-hooks-worker-asyncfn-terminate-4.js
  • some failures due to mimalloc warning
  • for file in (ls test/js/node/test/parallel); echo $file; bun-debug test /js/node/test/parallel/$file; end

Followup:

  • Support on linux
  • Support on windows
  • Maybe support in a ReleaseSafe build and run tests on that?

@robobun
Copy link

robobun commented Feb 5, 2025

Updated 3:39 PM PT - Feb 5th, 2025

@pfgithub, your commit ed43cb2 has 1 failures in Build #11146:


🧪   try this PR locally:

bunx bun-pr 17058

@pfgithub pfgithub marked this pull request as ready for review February 5, 2025 22:44
@Jarred-Sumner Jarred-Sumner merged commit 5620a7d into main Feb 6, 2025
66 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the pfg/asan branch February 6, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants