Introduce bun install --analyze <files...>
#17035
Open
+1,375
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 9:46 PM PT - Feb 5th, 2025
❌ @Jarred-Sumner, your commit 0569304 has 1 failures in
🧪 try this PR locally: bunx bun-pr 17035 |
|
Ideas for flag name: |
dylan-conway
reviewed
Feb 4, 2025
Comment on lines
+1493
to
+1499
| } else if (strings.indexOfChar(record.path.text, '/')) |slash_index| { | ||
| if (slash_index > 0) { | ||
| package_path = record.path.text[0..slash_index]; | ||
| } | ||
| } else { | ||
| package_path = record.path.text; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } else if (strings.indexOfChar(record.path.text, '/')) |slash_index| { | |
| if (slash_index > 0) { | |
| package_path = record.path.text[0..slash_index]; | |
| } | |
| } else { | |
| package_path = record.path.text; | |
| } | |
| } else if (!strings.containsChar(record.path.text, '/')) { | |
| package_path = record.path.text; | |
| } |
Reasoning: the package shouldn't contain / if it doesn't start with @
There was a problem hiding this comment.
or, this could just be else { package_path = record.path.text } and let strings.isNPMPackageName handle invalid name
dylan-conway
reviewed
Feb 4, 2025
| @@ -1487,6 +1546,11 @@ pub const BundleV2 = struct { | |||
| const reachable_files = try this.findReachableFiles(); | |||
| reachable_files_count.* = reachable_files.len -| 1; // - 1 for the runtime | |||
|
|
|||
| if (fetcher) |fetch| { | |||
| try this.getAllDependencies(reachable_files, fetch); | |||
| return std.ArrayList(options.OutputFile).init(allocator); | |||
There was a problem hiding this comment.
Suggested change
| return std.ArrayList(options.OutputFile).init(allocator); | |
| .init(allocator); |
Not important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
bun install --analyze <files ...>scans imported packages from source files using Bun's bundler and adds any missing ones to package.jsonHow did you verify your code works?
WIP