Enable sessionToken to be unset in S3Client
#16817
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksrandall
force-pushed
the
nick/s3-session-token
branch
from
0d94d99 to
0a44a22
Compare
cirospaciari
requested changes
Jan 28, 2025
Co-authored-by: Ciro Spaciari <[email protected]>
nicksrandall
force-pushed
the
nick/s3-session-token
branch
from
acb28d6 to
8d3403a
Compare
cirospaciari
approved these changes
Jan 29, 2025
cirospaciari
requested changes
Jan 29, 2025
There was a problem hiding this comment.
LGTM for the test In test/js/bun/s3/s3.test.ts we should be able to start a process passing the credentials and a invalid sessionToken in the env, using Bun.spawn, and write/read to the bucket cleaning the sessionToken parameter, check bunExe, bunEnv and allCredentials, we can exit 1 for a error and exit 0 if everything is right, and check the exitCode
|
@cirospaciari I tried to write a test but I actually couldn't figure out how to get it to work. I might need some help finishing this PR. |
Sure will help you with that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #16810
This PR enables users to opt out of using the
AWS_SESSION_TOKENenvironment variable when using the S3Client. This is useful for users who are using Bun in an environment where theAWS_SESSION_TOKENenvironment variable is set, but they do not want to use it (eg AWS Lambda functions, or session token is being used for another purpose).WIth this change, users can opt out of using the
AWS_SESSION_TOKEN(andS3_SESSION_TOKEN) by passingnullto thesessionTokenproperty in constructor.How did you verify your code works?