Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement process.binding('buffer') #16741

Merged
merged 6 commits into from
Feb 5, 2025
Merged

implement process.binding('buffer') #16741

merged 6 commits into from
Feb 5, 2025

Conversation

nektro
Copy link
Member

@nektro nektro commented Jan 25, 2025

continued from #15722

closes #2020

@robobun
Copy link

robobun commented Jan 25, 2025

Updated 5:59 PM PT - Feb 4th, 2025

@nektro, your commit 9349f81 has 1 failures in Build #11100:


🧪   try this PR locally:

bunx bun-pr 16741

@nektro
Copy link
Member Author

nektro commented Jan 25, 2025

windows build error
bun\build\release-ci\codegen\ProcessBindingBuffer.lut.h(80,87):
error: no matching constructor for initialization of 'union ValueStorage'

@nektro nektro marked this pull request as ready for review January 28, 2025 02:24
@nektro nektro requested review from a team and Jarred-Sumner and removed request for a team January 28, 2025 02:24
@nektro nektro requested a review from paperclover February 4, 2025 06:27
@nektro nektro merged commit b39d846 into main Feb 5, 2025
66 of 69 checks passed
@nektro nektro deleted the nektro-patch-61526 branch February 5, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement process.binding("buffer")
4 participants