Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: fix buffer includes+indexof #16642

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

node: fix buffer includes+indexof #16642

wants to merge 9 commits into from

Conversation

nektro
Copy link
Member

@nektro nektro commented Jan 23, 2025

pulled out of #15722

@robobun
Copy link

robobun commented Jan 23, 2025

Updated 6:48 PM PT - Feb 5th, 2025

@nektro, your commit e2e6d33 has some failures in Build #11158


🧪   try this PR locally:

bunx bun-pr 16642

@nektro nektro marked this pull request as ready for review January 23, 2025 07:37
@nektro nektro requested review from Jarred-Sumner and a team January 24, 2025 05:53
@nektro nektro requested a review from Jarred-Sumner January 25, 2025 06:05
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions and nitpicks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants