Introduce experimental support for on-demand bundling via HTML imports and Bun.serve() #16395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperclover
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
fwiw tests are not a blocker for merging as this is an experimental feature. focus on figuring out how these HTML bundles will be configurable since the with { ... } argument is kind of lame.
other things i think about:
- taking a directory tree of HTML files, since file system routing is optimal for generated pages
- a way to have parts or the whole html file generated by javascript / easily SSR an initial app shell or use HTML bundler as a SSG.
these two use cases should not be worked on yet, but just kept in mind as ways the HTML bundling api will expand over time.
| @@ -35,43 +35,7 @@ namespace uWS { | |||
|
|
|||
| template <class USERDATA> | |||
| struct HttpRouter { | |||
| /* These are public for now */ | |||
| std::vector<std::string> upperCasedMethods = { | |||
There was a problem hiding this comment.
this reminded me that bun currently doesnt support exotic method strings like walawala, instead defaulting them to get. but this diff is just uws updating so it ok.
paperclover
reviewed
Jan 14, 2025
| this.doWriteHeaders(resp); | ||
| } | ||
|
|
||
| const StaticRoute = @This(); |
There was a problem hiding this comment.
nit: make this the first non-comment line. it makes it very obvious to a reader that the file is a struct for that name. not a big deal, one day i'll write a lint to force the ordering of import constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a zero-configuration frontend production and frontend dev server to Bun.serve() behind the
--experimental-htmlflag.When navigating to
/, it will bundle./index.html, reading the<script>tags, bundling any JavaScript, CSS, and assets. Then, those assets get served automatically in Bun.serve(). Whendevelopment: trueis set, Bun.serve() will rebuild the assets on the next reload of the HTML, log on build error and print the build status on completion. When not set, Bun will minify the assets and only build lazily on the first request.This is an extremely rough, simple version of this feature and it will get better soon. Keep in mind:
bun buildsupport yet, still need to wire that up. The plan there is it will do this build step statically, and return a manifest which can then also be used in Node or CF Workers or elsewhereHow did you verify your code works?