Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli/bunx): support --no-install flag #16315

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jan 11, 2025

What does this PR do?

Closes #16065.

Note that the current implementation has similar limitations to npx. Althought matching behavior is "correct" in a strict sense, there are tweaks we could do here for a better developer experience. I'll list them out in an issue, and maybe implement some of them in an downstack pr.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests

@robobun
Copy link

robobun commented Jan 11, 2025

Updated 12:38 AM PT - Jan 11th, 2025

@DonIsaac, your commit 752ed48 has passed in #9452! 🎉


🧪   try this PR locally:

bunx bun-pr 16315

Copy link
Contributor Author

DonIsaac commented Jan 11, 2025

@DonIsaac DonIsaac changed the title add unit tests feat(bunx): support --no-install flag Jan 11, 2025
@DonIsaac DonIsaac added bunx Something that has to do with `bunx` enhancement New feature or request labels Jan 11, 2025 — with Graphite App
@DonIsaac DonIsaac linked an issue Jan 11, 2025 that may be closed by this pull request
@DonIsaac DonIsaac changed the title feat(bunx): support --no-install flag feat(cli/bunx): support --no-install flag Jan 11, 2025
@DonIsaac DonIsaac force-pushed the don/feat/bunx-no-install branch from 86ae42d to 1e57748 Compare January 11, 2025 00:26
@DonIsaac DonIsaac marked this pull request as ready for review January 11, 2025 00:26
@DonIsaac DonIsaac requested a review from dylan-conway January 11, 2025 00:26
@DonIsaac DonIsaac force-pushed the don/feat/bunx-no-install branch from 1e57748 to 5e124a6 Compare January 11, 2025 01:06
@DonIsaac DonIsaac changed the base branch from 01-10-refactor_cmd_bunx_extract_options_data_into_options_struct to graphite-base/16315 January 11, 2025 01:10
@DonIsaac DonIsaac force-pushed the graphite-base/16315 branch from 1f142d6 to 18f9ecf Compare January 11, 2025 01:54
@DonIsaac DonIsaac force-pushed the don/feat/bunx-no-install branch from 5e124a6 to 9a3bba6 Compare January 11, 2025 01:54
@DonIsaac DonIsaac changed the base branch from graphite-base/16315 to main January 11, 2025 01:55
Copy link

graphite-app bot commented Jan 11, 2025

Merge activity

  • Jan 10, 8:55 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Jan 11, 4:06 AM EST: Graphite couldn't merge this PR because it failed for an unknown reason (This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite).

@DonIsaac DonIsaac enabled auto-merge January 11, 2025 01:55
@DonIsaac DonIsaac force-pushed the don/feat/bunx-no-install branch 2 times, most recently from 5b91870 to 0d03265 Compare January 11, 2025 03:53
@DonIsaac DonIsaac force-pushed the don/feat/bunx-no-install branch from eed6da0 to fbedf36 Compare January 11, 2025 04:59
@DonIsaac DonIsaac added this pull request to the merge queue Jan 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 11, 2025
@Jarred-Sumner Jarred-Sumner merged commit ab3ac07 into main Jan 13, 2025
70 checks passed
@Jarred-Sumner Jarred-Sumner deleted the don/feat/bunx-no-install branch January 13, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bunx Something that has to do with `bunx` enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support bunx --no-install
4 participants