Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): toThrow() === toThrow('') #16308

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix(test): toThrow() === toThrow('') #16308

merged 1 commit into from
Jan 10, 2025

Conversation

DonIsaac
Copy link
Contributor

What does this PR do?

fixes #16145.

How did you verify your code works?

I wrote tests

@DonIsaac DonIsaac added the bun:test Something related to the `bun test` runner label Jan 10, 2025
@robobun
Copy link

robobun commented Jan 10, 2025 •
edited
Loading

Updated 12:46 AM PT - Jan 10th, 2025

✅ @DonIsaac, your commit b8db81b has passed in #9360! 🎉

🧪   try this PR locally:

bunx bun-pr 16308

@DonIsaac DonIsaac requested review from Electroid, a team and cirospaciari and removed request for a team January 10, 2025 08:13
@Jarred-Sumner Jarred-Sumner merged commit 5e584e9 into main Jan 10, 2025
69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the don/fix/test-tothrow-empty-string branch January 10, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electroid Electroid Awaiting requested review from Electroid

@cirospaciari cirospaciari Awaiting requested review from cirospaciari cirospaciari was automatically assigned from oven-sh/code-reviewers

Assignees
No one assigned
Labels
bun:test Something related to the `bun test` runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.toThrow("") should be the same as .toThrow()
3 participants
@DonIsaac @robobun @Jarred-Sumner