Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing x-amz-acl header #16260

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add missing x-amz-acl header #16260

merged 1 commit into from
Jan 10, 2025

Conversation

Gobd
Copy link
Contributor

@Gobd Gobd commented Jan 8, 2025

What does this PR do?

Closes #16255

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@DonIsaac DonIsaac requested a review from cirospaciari January 8, 2025 21:59
@DonIsaac
Copy link
Contributor

DonIsaac commented Jan 8, 2025

Thanks for the PR @Gobd. It would be a big help if you could also add some test cases.

@Gobd
Copy link
Contributor Author

Gobd commented Jan 8, 2025

Sorry I'm not sure how I'd write a test for this :(

@Gobd
Copy link
Contributor Author

Gobd commented Jan 9, 2025

@cirospaciari using bunx bun-pr 16260 I can confirm that this fixes the issue

cirospaciari
cirospaciari approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@cirospaciari cirospaciari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I missed this in a merge will add someway of testing this so we dont have regretions, your fix is correct in fact.

@cirospaciari cirospaciari enabled auto-merge January 9, 2025 23:15
@cirospaciari cirospaciari added this pull request to the merge queue Jan 10, 2025
@cirospaciari cirospaciari self-assigned this Jan 10, 2025
Merged via the queue into oven-sh:main with commit 0b9db36 Jan 10, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cirospaciari cirospaciari cirospaciari approved these changes

Assignees

@cirospaciari cirospaciari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bun S3 acl option does not work
3 participants
@Gobd @DonIsaac @cirospaciari