-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start fixing bugs discovered by Node.js's Node-API tests #14501
base: main
Are you sure you want to change the base?
Conversation
Updated 11:29 AM PT - Feb 4th, 2025
❌ @190n, your commit eb00b43 has 3 failures in
🧪 try this PR locally: bunx bun-pr 14501 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the merge now. Should be OK to merge if CI passes.
Thanks for cleaning up the mess after I merged main into this branch :D |
NVM I broke up bigint tests. Will fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay
What does this PR do?
TODO before merging:
remove dependency on JSC change formerged JSC change insteadnapi_get_property_names
(@heimskr)Fixes #14336
Fixes #15383
Fixes #15429
Tests in
js-native-api
How did you verify your code works?
Running Node's tests