API: return error when no ports found (librenms#16043)

When looking up device ports (get_port_graphs), return an error when no ports are found. fixes librenms#15964
ottorei · May 22, 2024 · 54ec98c · 54ec98c
1 parent d4b7dbe
commit 54ec98c
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/includes/html/api_functions.inc.php b/includes/html/api_functions.inc.php
@@ -1070,6 +1070,10 @@ function get_port_graphs(Illuminate\Http\Request $request): JsonResponse
     $ports = $device->ports()->isNotDeleted()->hasAccess(Auth::user())
         ->select($columns)->orderBy('ifIndex')->get();
 
+    if ($ports->isEmpty()) {
+        return api_error(404, 'No ports found');
+    }
+
     return api_success($ports, 'ports');
 }