Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build target to Makefile #5

Merged
merged 4 commits into from
Sep 4, 2021
Merged

Conversation

scabala
Copy link
Contributor

@scabala scabala commented Aug 24, 2021

Closes #2

Changelog:

  • added separate build target to Makefile.
  • modified install Makefile target to only copy files around

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@otsaloma
Copy link
Owner

Also, two questions

  1. What does this setup.py build/install split practically mean here? Because it seems to me that build only copies the files under the build directory and only once you run the install command, does it do some byte-compilation and egg creation. I'm just wondering if this setup.py build/install split makes some sense here?
  2. Is it all right to have both setup.py and our Makefile commands write to the same build directory? I'm just checking that it doesn't disturb or confuse setup.py somehow?

@scabala
Copy link
Contributor Author

scabala commented Sep 1, 2021

  1. Yes, indeed it does only copy files around. However, I would like to keep it separate. I don't know much about DEB side of the Force but in RPM land, I've seen spec files only with build and install calls to setup.py sepatated.
  2. AFAIK, it does not. It has the benefit of having all build files in the same directory.

@otsaloma
Copy link
Owner

otsaloma commented Sep 4, 2021

Thanks, I think this looks good now, merging.

@otsaloma otsaloma merged commit 064a8c8 into otsaloma:master Sep 4, 2021
otsaloma added a commit that referenced this pull request Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'build' and 'uninstall' make targets
2 participants