Using string.Builder to generate warning message, as the linter consi…

…dered the line too long.

Signed-off-by: Simon Heidrich <[email protected]>

clients/githubrepo/roundtripper/tokens/accessor.go

@@ -35,7 +35,13 @@ type TokenAccessor interface {
 }
 
 var logDuplicateTokenWarning = func(firstName string, clashingName string) {
-	log.Printf("Warning: PATs stored in env variables %s and %s differ. Scorecard will use the former.\n", firstName, clashingName)
+	var stringBuilder strings.Builder
+	stringBuilder.WriteString("Warning: PATs stored in env variables ")
+	stringBuilder.WriteString(firstName)
+	stringBuilder.WriteString(" and ")
+	stringBuilder.WriteString(clashingName)
+	stringBuilder.WriteString(" differ. Scorecard will use the former.")
+	log.Println(stringBuilder.String())
 }
 
 func readGitHubTokens() (string, bool) {

clients/githubrepo/roundtripper/tokens/accessor_test.go

@@ -90,7 +90,6 @@ func testServer(t *testing.T) {
 	}
 }
 
-//nolint:paralleltest // test uses t.Setenv indirectly
 func TestClashingTokensDisplayWarning(t *testing.T) {
 	unsetTokens(t)
 
@@ -119,7 +118,6 @@ func TestClashingTokensDisplayWarning(t *testing.T) {
 	}
 }
 
-//nolint:paralleltest // test uses t.Setenv indirectly
 func TestConsistentTokensDoNotDisplayWarning(t *testing.T) {
 	unsetTokens(t)