Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a milestone 1 doc. #118

Merged
merged 4 commits into from
May 2, 2022
Merged

Add a milestone 1 doc. #118

merged 4 commits into from
May 2, 2022

Conversation

calebbrown
Copy link
Contributor

@calebbrown calebbrown commented Apr 29, 2022

This doc describes work towards solving issue #108

@calebbrown
Copy link
Contributor Author

After this doc is submitted (at least the first version) I will create a milestone and point it to this doc.

Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Just some comments/suggestions to make the main points of milestone 1 come across a bit clearer.

docs/design/milestone_1.md Outdated Show resolved Hide resolved
docs/design/milestone_1.md Outdated Show resolved Hide resolved
docs/design/milestone_1.md Outdated Show resolved Hide resolved
Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one last comment!

docs/design/milestone_1.md Outdated Show resolved Hide resolved
@calebbrown calebbrown merged commit 352a60f into main May 2, 2022
@calebbrown calebbrown deleted the docs branch May 2, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants