different samples treated as replicates #514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #512
Throws an error if there are any missing values in the
sample
column of the contaminants file. (Only likely to happen with external data.)Also checks for non-unique sample identifiers, for example when the same sample identifier has been used in different years, or for different stations or species. If this occurs, then a warning is printed exhorting the user to sort out their contaminants data file. But if they don't an attempt is made to create unique sample identifiers by pasting together
year
,station_code
,species
(biota only) andsample
. This should work in most situations.Have updated the vignette on the external data file format to point out the need for unique sample identifiers (across years, stations, species, etc.)
Tested on HELCOM and external data