Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different samples treated as replicates #514

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

RobFryer
Copy link
Contributor

resolves #512

Throws an error if there are any missing values in the sample column of the contaminants file. (Only likely to happen with external data.)

Also checks for non-unique sample identifiers, for example when the same sample identifier has been used in different years, or for different stations or species. If this occurs, then a warning is printed exhorting the user to sort out their contaminants data file. But if they don't an attempt is made to create unique sample identifiers by pasting together year, station_code, species (biota only) and sample. This should work in most situations.

Have updated the vignette on the external data file format to point out the need for unique sample identifiers (across years, stations, species, etc.)

Tested on HELCOM and external data

@annelaerkes annelaerkes merged commit 52a8431 into osparcomm:develop Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants