Remove any related multilingual keys from templates #10378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves osmlab#7236 Resolves osmlab#9260
Dimitar5555
added a commit
that referenced
this pull request
Jan 29, 2025
Quite a few banks have `official_name`, `alt_name` or `short_name`. If we are removing name from ATMs, we should remove the above mentioned tags as well. Blocked by #10378
|
I think it's better to use the templateTags property to control which tags get copied into the ATMs, rather than hardcoding the tags that you want to exclude in the file reader code. |
|
That is what I've done in #10414. This PR defines which keys should be considered multilingual (i.e. have language suffix) in order to remove them IF they are present in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7236
Resolves #9260
I might've missed or overlooked something so please test this change. Other than that it seems to produce correct results.
P.S. Quite a few banks have
official_name,alt_nameorshort_name. If we are removingnamefrom ATMs, we should remove the above mentioned tags as well.