Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding product from wishlist to cart #194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomaszsita
Copy link

Fixed the problem with wrong price of configurable product option being
added to cart from the wishlist.

#132

Fixed the problem with wrong price of configurable product option being
added to cart from the wishlist.

organicinternet#132
@cristian-v
Copy link

Sorry to disappoint you but is only partially fixed. If you have a special price is displaying only the normal price. Fix would be to change in the recently added code from $childProduct->getPrice(); to $childProduct->getFinalPrice(); and add the same code in the method getPrice.

@tmotyl
Copy link

tmotyl commented Aug 11, 2014

also to check "if ($buyRequest) {" is not enough. As in Magento you can also add "unconfigured" configurable product to the cart. In that case with your patch Fatal error will be thrown
as
$product->getCustomOption('info_buyRequest')->getItem()->getOptionByCode('simple_product')
will return null in that case

@minc21
Copy link

minc21 commented Sep 15, 2015

Hello,
same fatal error here!
Has anyone a working wishlist-fix?

@minc21
Copy link

minc21 commented Sep 23, 2015

Hello,
I've added a is_object to the if condition ... it seems to work.

if ($buyRequest and is_object($product->getCustomOption('info_buyRequest')->getItem()->getOptionByCode('simple_product')))

maybe anyone with a deeper knowledge can comment on this solution?

cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants