-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solves #62: Remove all dependencies on Guava #63
Conversation
a0c17ab
to
fc13cff
Compare
fc13cff
to
1211f82
Compare
@kwin here is a PR. Can you please validate it from your side :)? |
bundle/src/main/groovy/be/orbinson/aem/groovy/console/servlets/ScriptPostServlet.groovy
Outdated
Show resolved
Hide resolved
...test/groovy/be/orbinson/aem/groovy/console/extension/impl/DefaultExtensionServiceTest.groovy
Outdated
Show resolved
Hide resolved
api/src/main/groovy/be/orbinson/aem/groovy/console/api/JobProperties.groovy
Outdated
Show resolved
Hide resolved
...orbinson/aem/groovy/console/extension/impl/startimport/AemStarImportExtensionProvider.groovy
Outdated
Show resolved
Hide resolved
You should definitely use https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html to check against the Java API you claim to be compatiblewith. |
@kwin I spent an hour trying to get it to work, but didn't get it working. Probably the actual compiler (groovy-eclipse-compiler) does not take the |
Once AEM goes for a Java 17 / 21 release, I'll see if we will drop Java 8. No requirements at this moment to do so, seeing as we can use all Groovy syntax additions to add most things we want |
You can use https://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/index.html instead as that works on the compiled classes (i.e. independent which compiler generated those) |
The animal sniffer plugin also doesn't seem to work properly with the code generated by Groovy either. Going to merge this PR as is for now |
|
No description provided.