solves #56 Add Groovyconsole to Tools and update the project to not have colliding filters anymore

CHANGELOG.md

@@ -7,9 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Add Groovy console to the Tools menu [#56](https://github.com/orbinson/aem-groovy-console/issues/56)
+
 ### Changed
 
 -  Remove all dependencies on Guava [#62](https://github.com/orbinson/aem-groovy-console/issues/62)
+-  Fix Cloud pipeline package Overlap Issue [#52](https://github.com/orbinson/aem-groovy-console/issues/52)
 
 ## [19.0.5] - 2024-02-10
 

all/pom.xml

@@ -37,6 +37,8 @@
                     <properties>
                         <cloudManagerTarget>all</cloudManagerTarget>
                     </properties>
+                    <!-- all sub packages have been validated already -->
+                    <skipSubPackageValidation>true</skipSubPackageValidation>
                     <embeddeds>
                         <embedded>
                             <groupId>be.orbinson.aem</groupId>

pom.xml

@@ -24,7 +24,6 @@
         <module>groovy</module>
         <module>ui.apps</module>
         <module>ui.apps.aem</module>
-        <module>ui.apps.structure</module>
         <module>ui.config</module>
         <module>ui.content</module>
     </modules>
@@ -349,7 +348,7 @@
                     <groupId>org.apache.jackrabbit</groupId>
                     <artifactId>filevault-package-maven-plugin</artifactId>
                     <extensions>true</extensions>
-                    <version>1.1.4</version>
+                    <version>1.3.6</version>
                     <configuration>
                         <filterSource>src/main/content/META-INF/vault/filter.xml</filterSource>
                         <properties>

ui.apps.aem/pom.xml

@@ -23,7 +23,6 @@
                     <group>${project.artifactId}</group>
                     <name>aem-groovy-console-ui.apps.aem</name>
                     <packageType>application</packageType>
-                    <accessControlHandling>merge</accessControlHandling>
                     <properties>
                         <cloudManagerTarget>none</cloudManagerTarget>
                     </properties>
@@ -36,12 +35,17 @@
                     <validatorsSettings>
                         <jackrabbit-filter>
                             <options>
-                                <validRoots>/apps/groovyconsole/components/console</validRoots>
+                                <validRoots>/apps,/apps/cq/core/content</validRoots>
                             </options>
                         </jackrabbit-filter>
                         <jackrabbit-nodetypes>
                             <isDisabled>true</isDisabled>
                         </jackrabbit-nodetypes>
+                        <jackrabbit-packagetype>
+                            <options>
+                                <allowComplexFilterRulesInApplicationPackages>true</allowComplexFilterRulesInApplicationPackages>
+                            </options>
+                        </jackrabbit-packagetype>
                     </validatorsSettings>
                 </configuration>
             </plugin>

ui.apps.aem/src/main/content/META-INF/vault/filter.xml

@@ -1,6 +1,11 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <workspaceFilter version="1.0">
-    <filter root="/apps/groovyconsole/clientlibs-aem"/>
-    <filter root="/apps/groovyconsole/components/console/opendialog"/>
-    <filter root="/apps/groovyconsole/components/console/savedialog"/>
+    <filter root="/apps/groovyconsole-aem"/>
+
+    <filter root="/apps/cq/core/content/nav">
+        <include pattern="/apps/cq/core/content/nav"/>
+        <include pattern="/apps/cq/core/content/nav/tools"/>
+        <include pattern="/apps/cq/core/content/nav/tools/general"/>
+        <include pattern="/apps/cq/core/content/nav/tools/general/groovyconsole(.*)?"/>
+    </filter>
 </workspaceFilter>

ui.apps.aem/src/main/content/jcr_root/apps/cq/.content.xml

@@ -0,0 +1,3 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:rep="internal"
+    jcr:primaryType="sling:OrderedFolder"/>

ui.apps.aem/src/main/content/jcr_root/apps/cq/core/content/.content.xml

@@ -0,0 +1,3 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:rep="internal"
+    jcr:primaryType="sling:OrderedFolder"/>

ui.apps.aem/src/main/content/jcr_root/apps/cq/core/content/nav/.content.xml

@@ -0,0 +1,3 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:rep="internal"
+    jcr:primaryType="sling:OrderedFolder"/>

ui.apps.aem/src/main/content/jcr_root/apps/cq/core/content/nav/tools/.content.xml

@@ -0,0 +1,3 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:rep="internal"
+    jcr:primaryType="sling:OrderedFolder"/>

ui.apps.aem/src/main/content/jcr_root/apps/cq/core/content/nav/tools/general/.content.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0"
+          jcr:primaryType="sling:OrderedFolder">
+</jcr:root>

ui.apps.aem/src/main/content/jcr_root/apps/cq/core/content/nav/tools/general/groovyconsole/.content.xml

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0"
+          xmlns:nt="http://www.jcp.org/jcr/nt/1.0"
+          jcr:description="The AEM Groovy Console provides an interface for running Groovy scripts"
+          jcr:primaryType="nt:unstructured"
+          jcr:title="AEM Groovy Console"
+          href="/apps/groovyconsole.html"
+          icon="actions"
+          id="granite-general-groovyconsole">
+</jcr:root>

ui.apps.aem/src/main/content/jcr_root/apps/groovyconsole/components/console/.content.xml → ui.apps.aem/src/main/content/jcr_root/apps/groovyconsole-aem/.content.xml

@@ -1,4 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0"
           xmlns:jcr="http://www.jcp.org/jcr/1.0"
-          jcr:primaryType="sling:Folder"/>
+          jcr:primaryType="sling:Folder">
+</jcr:root>

ui.apps.aem/src/main/content/jcr_root/apps/groovyconsole/clientlibs-aem/.content.xml → ui.apps.aem/src/main/content/jcr_root/apps/groovyconsole-aem/clientlibs/.content.xml

@@ -4,4 +4,4 @@
           jcr:primaryType="cq:ClientLibraryFolder"
           categories="[groovyconsole]"
           allowProxy="{Boolean}true"
-          dependencies="[cq.shared]"/>
+          dependencies="[cq.shared]"/>

ui.apps.aem/src/main/content/jcr_root/apps/groovyconsole/clientlibs-aem/css.txt → ui.apps.aem/src/main/content/jcr_root/apps/groovyconsole-aem/clientlibs/css.txt

@@ -1,7 +1,7 @@
-#base=../clientlibs/css
+#base=/apps/groovyconsole/clientlibs/css
 
 bootstrap.css
 bootstrap-theme.css
 daterangepicker.css
 datatables.css
-console.css
+console.css

ui.apps.aem/src/main/content/jcr_root/apps/groovyconsole/clientlibs-aem/js.txt → ui.apps.aem/src/main/content/jcr_root/apps/groovyconsole-aem/clientlibs/js.txt

@@ -1,4 +1,4 @@
-#base=../clientlibs/js
+#base=/apps/groovyconsole/clientlibs/js
 
 datatables.js
 jquery-ui.min.js
@@ -53,4 +53,4 @@ console.js
 services.js
 audit.js
 scheduled-jobs.js
-local-storage.js
+local-storage.js

ui.apps/pom.xml

@@ -23,16 +23,9 @@
                     <group>${project.artifactId}</group>
                     <name>aem-groovy-console-ui.apps</name>
                     <packageType>application</packageType>
-                    <accessControlHandling>merge</accessControlHandling>
                     <properties>
                         <cloudManagerTarget>none</cloudManagerTarget>
                     </properties>
-                    <repositoryStructurePackages>
-                        <repositoryStructurePackage>
-                            <groupId>be.orbinson.aem</groupId>
-                            <artifactId>aem-groovy-console-ui.apps.structure</artifactId>
-                        </repositoryStructurePackage>
-                    </repositoryStructurePackages>
                     <validatorsSettings>
                         <jackrabbit-nodetypes>
                             <isDisabled>true</isDisabled>

ui.apps/src/main/content/jcr_root/apps/groovyconsole/clientlibs/.content.xml

@@ -2,4 +2,4 @@
 <jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0"
           jcr:primaryType="sling:OrderedFolder"
           sling:resourceType="composum/nodes/commons/clientlib"
-          category="[groovyconsole]"/>
+          category="[groovyconsole]"/>

ui.apps/src/main/content/jcr_root/apps/groovyconsole/clientlibs/js/console.js

@@ -540,15 +540,23 @@ var GroovyConsole = function () {
     },
 
     showOpenDialog: function () {
-      var dialog = CQ.WCM.getDialog('/apps/groovyconsole/components/console/opendialog');
+      if (typeof CQ !== undefined) {
+        var dialog = CQ.WCM.getDialog('/apps/groovyconsole-aem/dialogs/opendialog');
 
-      dialog.show();
+        dialog.show();
+      } else {
+        alert("Open and saving currently only supported in AEM")
+      }
     },
 
     showSaveDialog: function () {
-      var dialog = CQ.WCM.getDialog('/apps/groovyconsole/components/console/savedialog');
+        if (typeof CQ !== undefined) {
+            var dialog = CQ.WCM.getDialog('/apps/groovyconsole-aem/dialogs/savedialog');
 
-      dialog.show();
+            dialog.show();
+        } else {
+            alert("Open and saving currently only supported in AEM")
+        }
     },
 
     loadScript: function (scriptPath) {

ui.content/pom.xml

@@ -23,7 +23,6 @@
                     <group>${project.artifactId}</group>
                     <name>aem-groovy-console-ui.content</name>
                     <packageType>content</packageType>
-                    <accessControlHandling>merge</accessControlHandling>
                     <properties>
                         <cloudManagerTarget>none</cloudManagerTarget>
                     </properties>