backfills tests for behaviour on malformed due to non-string tags #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <[email protected]>
| @@ -222,7 +221,9 @@ public static <T> void writeList(WriteBuffer.Writer<T> writer, List<T> value, Wr | |||
|
|
|||
| static IllegalArgumentException exceptionReading(String type, Exception e) { | |||
| String cause = e.getMessage() == null ? "Error" : e.getMessage(); | |||
| if (cause.contains("Expected BEGIN_OBJECT") || cause.contains("malformed")) { | |||
| if (cause.contains("Expected BEGIN_OBJECT") | |||
There was a problem hiding this comment.
while this normalizes the error as intended, this PR already shows any data that has malformed tags in zipkin were created out-of-band, like not using zipkin, as all collectors regardless of HTTP or Kafka use this path
codefromthecrypt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests to prove that all zipkin collectors return errors when json is malformed due to non-string tags.
See #3503 (comment)