Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zio_resume: log when unsuspending the pool #16485

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

robn
Copy link
Member

@robn robn commented Aug 28, 2024

[Sponsors: Klara, Inc., Wasabi Technology, Inc.]

Motivation and Context

Sometimes we get logs from customers and its easy to see when the pool suspended, and much harder to figure out when they resumed it.

Description

When the pool is resumed, spit some output in the style of the suspend log.

Because zio_resume() is called any time zpool clear is run, only logs on transition from suspended to not-suspended.

How Has This Been Tested?

Just a dumb suspend & resume on the test rig:

[    7.952215] WARNING: Pool 'tank' has encountered an uncorrectable I/O failure and has been suspended.

# zpool clear tank
[   17.626131] WARNING: Pool 'tank' was suspended and is being resumed. Failed I/O will be retried.

I have a ZTS run in progress, but I'm not expecting anything in it to care.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 28, 2024
@robn robn force-pushed the zio-resume-log branch 3 times, most recently from 94c3eaa to 9182fff Compare September 4, 2024 22:41
When reviewing logs after a failure, its useful to see where
unsuspend/resume was requested.

Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
@tonyhutter tonyhutter merged commit 8be2f4c into openzfs:master Sep 10, 2024
23 checks passed
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Jan 26, 2025
When reviewing logs after a failure, its useful to see where
unsuspend/resume was requested.


Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.

Signed-off-by: Rob Norris <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants