Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split engine translations into providers and modes #5652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hlfan
Copy link
Contributor

@hlfan hlfan commented Feb 11, 2025

Attempt to fix #5629.
If this isn't acceptable for translateWiki please provide an alternative

@tomhughes
Copy link
Member

You should never edit any translation here (other than en.yml obviously) so you need to remove all those changes and let Translatewiki handle them.

@hlfan
Copy link
Contributor Author

hlfan commented Feb 11, 2025

Doesn't this mean all the translations will have to start from scratch?
Then it could take years until some translations will be back.

fossgis_valhalla_bicycle: "Bicycle (Valhalla)"
fossgis_valhalla_car: "Car (Valhalla)"
fossgis_valhalla_foot: "Foot (Valhalla)"
fossgis_osrm: "OSRM"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does these engine names need a translation key?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the only possible solution is to discard every related translation, I would not let the engines be translated.
However, I understand why these were transliterated for non-Latin scripts; my goal here was to keep as many translations as possible, including the engine names.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Translatewiki is able to migrate moved translations but basically don't worry about it - we move things around all the time and it sorts itself out.

@tomhughes
Copy link
Member

If you want this to be considered for merging then you should remove the draft flag.

That said I'm not sure I really see the point of it - is this really just to reduce the number of translations from 9 to 6 so saving a total of 3 translations? All while introducing new "lego" to the translations though admittedly one that is probably relatively harmless.

@hlfan
Copy link
Contributor Author

hlfan commented Feb 13, 2025

The issues laid out in #5629 aren't page-breaking, but IMO changing to a system that removes the possibility of inconsistencies entirely is worth the lego.
Usually, only 3 translations for the modes are needed, only the non-Latin scripts need the graceful fallback.
And it's a step in the direction of #3123 if you wanna see it that way.

@hlfan hlfan marked this pull request as ready for review February 13, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split the combined directions engines translations into routers and modes
3 participants