-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split engine translations into providers and modes #5652
base: master
Are you sure you want to change the base?
Conversation
You should never edit any translation here (other than |
Doesn't this mean all the translations will have to start from scratch? |
fossgis_valhalla_bicycle: "Bicycle (Valhalla)" | ||
fossgis_valhalla_car: "Car (Valhalla)" | ||
fossgis_valhalla_foot: "Foot (Valhalla)" | ||
fossgis_osrm: "OSRM" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does these engine names need a translation key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the only possible solution is to discard every related translation, I would not let the engines be translated.
However, I understand why these were transliterated for non-Latin scripts; my goal here was to keep as many translations as possible, including the engine names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe Translatewiki is able to migrate moved translations but basically don't worry about it - we move things around all the time and it sorts itself out.
65aa4d3
to
850471e
Compare
If you want this to be considered for merging then you should remove the draft flag. That said I'm not sure I really see the point of it - is this really just to reduce the number of translations from 9 to 6 so saving a total of 3 translations? All while introducing new "lego" to the translations though admittedly one that is probably relatively harmless. |
The issues laid out in #5629 aren't page-breaking, but IMO changing to a system that removes the possibility of inconsistencies entirely is worth the lego. |
Attempt to fix #5629.
If this isn't acceptable for translateWiki please provide an alternative