OCPBUGS-44674: Handle openshift-host-network namespace as special when it modifies

[k37y]

• Add condition in NetworkPolicy updateMatchCache to handle HostNetworkNamespace changes

[openshift-ci-robot]

@k37y: This pull request references Jira Issue OCPBUGS-44674, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• Add condition in NetworkPolicy updateMatchCache to handle HostNetworkNamespace changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k37y
Once this PR has been reviewed and has the lgtm label, please assign trozet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k37y]

/jira refresh

[openshift-ci-robot]

@k37y: This pull request references Jira Issue OCPBUGS-44674, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[k37y]

/assign @danwinship

[danwinship]

Ah! Yes, this seems right, but can you turn this into a helper function so we don't have the same logic in both selectNamespacesInternal and updateMatchCache? (Maybe npns.GetMatchVNID()?)

[danwinship]

openshift-sdn master is dead now (and in particular, there is no CI for openshift-sdn master any more). SDN bugs should be filed against 4.16 first, and then backported from there as needed. You can click the "Edit" button by the bug summary, and then that will let you change the base branch from openshift:master to openshift:release-4.16. (And you'll need to update the jira issue as well. You'll also need to create a dummy 4.17 version of the jira issue to make the 4.16 one "depends on", in order to get the openshift bots to be happy.)