Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: okd: Add step to embed all component images to final image #4388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

praveenkumar
Copy link
Contributor

This will helpful for offline run of the container image. It is also helpful for podman desktop scenario where only have to pull image once and run it fast even on slow network connnectivity.

By accident I deleted this branch from my fork and #4376 got closed and I am not able to reopen it :(

This will helpful for offline run of the container image. It is also
helpful for podman desktop scenario where only have to pull image once
and run it fast even on slow network connnectivity.
@openshift-ci-robot
Copy link

@praveenkumar: This pull request explicitly references no jira issue.

In response to this:

This will helpful for offline run of the container image. It is also helpful for podman desktop scenario where only have to pull image once and run it fast even on slow network connnectivity.

By accident I deleted this branch from my fork and #4376 got closed and I am not able to reopen it :(

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 7, 2025
@praveenkumar praveenkumar marked this pull request as ready for review January 7, 2025 15:08
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
@openshift-ci openshift-ci bot requested review from jogeo and pacevedom January 7, 2025 15:09
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: praveenkumar
Once this PR has been reviewed and has the lgtm label, please assign pacevedom for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor

ggiguash commented Jan 7, 2025

/assign @eslutsky
@eslutsky , please test the flow works properly before we merge this change.
We do not have automated tests for OKD, so we need to resort to manual testing instead.

Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

@praveenkumar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants