Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-44231: [release-4.17] capi/aws: bump provider for LB DNS lookup fix #9179

Merged
merged 3 commits into from
Nov 14, 2024
Merged

OCPBUGS-44231: [release-4.17] capi/aws: bump provider for LB DNS lookup fix #9179

merged 3 commits into from
Nov 14, 2024

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Nov 5, 2024

Manual cherry-pick of #8927

@r4f4
Copy link
Contributor Author

r4f4 commented Nov 5, 2024

/jira cherrypick OCPBUGS-36222

@openshift-ci-robot
Copy link
Contributor

@r4f4: Jira Issue OCPBUGS-36222 has been cloned as Jira Issue OCPBUGS-44231. Will retitle bug to link to clone.
/retitle OCPBUGS-44231: [release-4.17] capi/aws: bump provider for LB DNS lookup fix

In response to this:

/jira cherrypick OCPBUGS-36222

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.17] capi/aws: bump provider for LB DNS lookup fix OCPBUGS-44231: [release-4.17] capi/aws: bump provider for LB DNS lookup fix Nov 5, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-44231, which is invalid:

  • expected dependent Jira Issue OCPBUGS-36222 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry-pick of #8927

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 5, 2024
@openshift-ci openshift-ci bot requested review from andfasano and rna-afk November 5, 2024 14:13
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 5, 2024

/label platform/aws

@sadasu
Copy link
Contributor

sadasu commented Nov 5, 2024

/approve

@sadasu
Copy link
Contributor

sadasu commented Nov 5, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@gpei
Copy link
Contributor

gpei commented Nov 6, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 6, 2024
r4f4 added 3 commits November 6, 2024 08:53
@r4f4
OCPBUGS-36222: capi/aws: bump provider version to latest main
a1d29aa 
We need to bump capa to get a fix for the LB DNS name lookup issue.

Notable changes from `git log --oneline 3f3ce5610204..5b4f7c1ac`:
```
32ebcce58 🐛elbv2: wait for LB active state instead of resolving DNS name
7e0812f59 🌱 Bump CAPI to v1.8.4 (openshift#5061)
8f46a4d34 Allow to specify cidr block for default node nodeport ingress rule
```
@r4f4
capi/aws: update vendor
e6a6fb0
@r4f4
capi/aws: update CRD after CAPA bump
e6fbd28
@r4f4 r4f4 force-pushed the capa-remove-lb-dns-check-4.17 branch from a4ddaed to e6fbd28 Compare November 6, 2024 08:07
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 6, 2024

Update: rebased on top of current master to resolve merge conflicts. Dropped capi bump since it's been done by #9182

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 6, 2024

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node e6fbd28 link false /test e2e-aws-ovn-single-node
ci/prow/altinfra-e2e-aws-ovn-single-node e6fbd28 link false /test altinfra-e2e-aws-ovn-single-node
ci/prow/e2e-azurestack e6fbd28 link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor Author

r4f4 commented Nov 14, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 14, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-44231, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-36222 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-36222 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8b59074 into openshift:release-4.17 Nov 14, 2024
36 of 39 checks passed
@openshift-ci-robot
Copy link
Contributor

@r4f4: Jira Issue OCPBUGS-44231: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44231 has been moved to the MODIFIED state.

In response to this:

Manual cherry-pick of #8927

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.17.0-202411142203.p0.g8b59074.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.17.0-202411142203.p0.g8b59074.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.17.0-202411142203.p0.g8b59074.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.17.0-202411142203.p0.g8b59074.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@rna-afk rna-afk Awaiting requested review from rna-afk

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. platform/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@r4f4 @openshift-ci-robot @sadasu @gpei @patrickdillon @openshift-bot