Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-4076: Address tech debt in SourceSecretForm component #14633

Merged
merged 2 commits into from
Jan 10, 2025
Merged

CONSOLE-4076: Address tech debt in SourceSecretForm component #14633

merged 2 commits into from
Jan 10, 2025

Conversation

cajieh
Copy link
Contributor

@cajieh cajieh commented Dec 17, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 17, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2024 •
edited by openshift-ci bot
Loading

@cyril-ui-developer: This pull request references CONSOLE-4076 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from kyoto and spadgett December 17, 2024 16:59
@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2024
@cajieh cajieh force-pushed the refactor-sourcesecretform-component branch from 4642d0d to 42dc726 Compare January 2, 2025 13:41
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 2, 2025
@cajieh cajieh force-pushed the refactor-sourcesecretform-component branch 3 times, most recently from 37431fd to 1aabd37 Compare January 6, 2025 10:59
@cajieh cajieh force-pushed the refactor-sourcesecretform-component branch from 1aabd37 to d72a390 Compare January 6, 2025 13:16
@cajieh
Copy link
Contributor Author

cajieh commented Jan 6, 2025

/test e2e-gcp-console

@cajieh
Copy link
Contributor Author

cajieh commented Jan 7, 2025

/hold
Hold until the e2e failed test is fixed.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025
@cajieh cajieh force-pushed the refactor-sourcesecretform-component branch from d72a390 to c02e512 Compare January 7, 2025 15:31
@cajieh cajieh force-pushed the refactor-sourcesecretform-component branch from c02e512 to 20f210f Compare January 7, 2025 16:24
@cajieh
Copy link
Contributor Author

cajieh commented Jan 7, 2025

/cancel hold

@cajieh
Copy link
Contributor Author

cajieh commented Jan 7, 2025

/test e2e-gcp-console

@cajieh
Copy link
Contributor Author

cajieh commented Jan 7, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025
jhadvig
jhadvig approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Member

jhadvig commented Jan 8, 2025

This is a tech debt, so I'm adding
/label px-approved
/label docs-approved

QE Approver
/assign @yapei

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jan 8, 2025
@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jan 8, 2025
@yapei
Copy link
Contributor

yapei commented Jan 9, 2025

Ran some regression testings about Source Secret creation, edit and translation, no issues found
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 9, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2025 •
edited by openshift-ci bot
Loading

@cyril-ui-developer: This pull request references CONSOLE-4076 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig
Copy link
Member

jhadvig commented Jan 9, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 9, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e4649ad and 2 for PR HEAD 20f210f in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 38d1903 into openshift:master Jan 10, 2025
7 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.19.0-202501100441.p0.g38d1903.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@jhadvig jhadvig

@yapei yapei

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cajieh @openshift-ci-robot @jhadvig @yapei @openshift-bot @nitin-dhevar