Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG 1921521: util: convert VAULT_SKIP_VERIFY to "vaultCAVerify" KMS option #21

Merged
merged 1 commit into from
Feb 16, 2021
Merged

BUG 1921521: util: convert VAULT_SKIP_VERIFY to "vaultCAVerify" KMS option #21

merged 1 commit into from
Feb 16, 2021

Conversation

nixpanic
Copy link
Member

"VAULT_SKIP_VERIFY" is a standard Hashicorp Vault environment variable
(a string) that needs to get converted to the "vaultCAVerify"
configuration option in the Ceph-CSI format.

The value of "VAULT_SKIP_VERIFY" means the reverse of "vaultCAVerify",
this part was missing in the original conversion too.

Backport-off: ceph#1872
Signed-off-by: Niels de Vos [email protected]
(cherry picked from commit 2c38f84)

@nixpanic
util: convert VAULT_SKIP_VERIFY to "vaultCAVerify" KMS option
6e71a02 
"VAULT_SKIP_VERIFY" is a standard Hashicorp Vault environment variable
(a string) that needs to get converted to the "vaultCAVerify"
configuration option in the Ceph-CSI format.

The value of "VAULT_SKIP_VERIFY" means the reverse of "vaultCAVerify",
this part was missing in the original conversion too.

Signed-off-by: Niels de Vos <[email protected]>
(cherry picked from commit 2c38f84)
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Feb 16, 2021
@openshift-ci-robot
Copy link

@nixpanic: This pull request references Bugzilla bug 1921521, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "OCS 4.7.0" instead
  • expected dependent Bugzilla bug 1924792 to target a release in 4.8.0, but it targets "OCS 4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 1921521: util: convert VAULT_SKIP_VERIFY to "vaultCAVerify" KMS option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 16, 2021
@nixpanic nixpanic merged commit d1ddd26 into openshift:release-4.7 Feb 16, 2021
@openshift-ci-robot
Copy link

@nixpanic: All pull requests linked via external trackers have merged:

Bugzilla bug 1921521 has been moved to the MODIFIED state.

In response to this:

BUG 1921521: util: convert VAULT_SKIP_VERIFY to "vaultCAVerify" KMS option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ceph-csi that referenced this pull request Dec 1, 2021
@openshift-merge-robot
Merge pull request openshift#21 from ceph/devel
d446ba4 
Sync rhs:devel with ceph:devel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nixpanic @openshift-ci-robot