Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Serving manifests to 1.16 #3366

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jan 30, 2025

Fixes JIRA #

Proposed Changes

  • As per title.

@openshift-ci openshift-ci bot requested review from aliok and creydr January 30, 2025 14:57
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto skonto requested review from dsimansk and removed request for creydr January 30, 2025 14:58
@skonto skonto changed the title Bump serving manifests 1.16 Bump Serving manifests to 1.16 Jan 30, 2025
@skonto
Copy link
Contributor Author

skonto commented Jan 30, 2025

@creydr
Copy link
Member

creydr commented Jan 30, 2025

Error: GET https://quay.io/v2/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-136/kn-client-cli-artifacts/manifests/sha256:f983be49897be59dba1275f36bdd83f648663ee904e4f242599e9269fc354fd7: UNAUTHORIZED: access to the requested resource is not authorized; map[]

cc @dsimansk

This is probably because client didn't yet onboard to 1.16 and thus images are not published / repos created (openshift-knative/client#497 needs to get merged)

@dsimansk
Copy link
Contributor

dsimansk commented Feb 3, 2025

@skonto I've merged all the konflux's PR on the client side. Finally, it seems images are being built from 1.16 release branch. The above error should go away now.

@dsimansk
Copy link
Contributor

dsimansk commented Feb 3, 2025

./hack/verify-csv-revisions.sh
realpath: /home/runner/.kube/config: No such file or directory
Branch and Tag:  - 
Error: entity not found in registry
main.go:62: error during command execution: entity not found in registry
./hack/verify-csv-revisions.sh: line 24: repo_revision[$repo]: bad array subscript
make: *** [Makefile:384: verify-csv-revisions] Error 1

@creydr
Copy link
Member

creydr commented Feb 3, 2025

./hack/verify-csv-revisions.sh
realpath: /home/runner/.kube/config: No such file or directory
Branch and Tag:  - 
Error: entity not found in registry
main.go:62: error during command execution: entity not found in registry
./hack/verify-csv-revisions.sh: line 24: repo_revision[$repo]: bad array subscript
make: *** [Makefile:384: verify-csv-revisions] Error 1

Seems

image: "registry.redhat.io/openshift-serverless-1/kn-client-cli-artifacts-rhel8@sha256:f983be49897be59dba1275f36bdd83f648663ee904e4f242599e9269fc354fd7"
(and probably others), point to images from the 1.35 branch. I guess when the latest builds of those repos succeeded, updating the CSV (e.g. by running make generated-files) should fix it

@skonto
Copy link
Contributor Author

skonto commented Feb 3, 2025

Ok let me try that.

@creydr
Copy link
Member

creydr commented Feb 3, 2025

Ok let me try that.

Uh I see where this comes from. In the project.yaml we still refer client to the knative-1.15 tag and through get_app_version_from_tag this resolves to the quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-client-cli-artifacts repo. So I guess we need to ignore this failure, until all components point to the correct repo :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants