Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knative.dev/eventing component #3326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mvinkler
Copy link
Contributor

Update knative.dev/eventing component in vendor folder.

openshift-knative/eventing#989 needs to be propagated to vendor folder to fix failing TestJobSinkSuccess in Prow periodic jobs: link

@openshift-ci openshift-ci bot requested review from aliok and skonto January 13, 2025 09:42
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mvinkler
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mvinkler mvinkler requested review from mgencur and maschmid January 13, 2025 09:42
@mvinkler
Copy link
Contributor Author

Looks like this PR needs to merged first #3052

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants