Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ariane_pkg: remove unused localparam ISSUE_WIDTH #2710

Merged
merged 2 commits into from
Jan 16, 2025
Merged

ariane_pkg: remove unused localparam ISSUE_WIDTH #2710

merged 2 commits into from
Jan 16, 2025

Conversation

cathales
Copy link
Contributor

This localparam is not needed anymore.

@cathales
Copy link
Contributor Author

Verible seems broken

Download action repository 'chipsalliance/verible-formatter-action@main' (SHA:4a7c04ea202b2146752ff8d5fc26fb1db39db0e5)
Getting action download info
Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

So I pushed a suggestion there: chipsalliance/verible-formatter-action#23

@github-actions GitHub Actions
Copy link
Contributor

✔️ successful run, report available here.

@JeanRochCoulon JeanRochCoulon merged commit 7af0f2e into openhwgroup:master Jan 16, 2025
4 of 12 checks passed
@JeanRochCoulon JeanRochCoulon deleted the ariane_pkg-remove-unused-ISSUE_WIDTH branch January 16, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanRochCoulon JeanRochCoulon Awaiting requested review from JeanRochCoulon JeanRochCoulon is a code owner

@zarubaf zarubaf Awaiting requested review from zarubaf zarubaf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cathales @JeanRochCoulon