fix: nil context on volume detach and state change #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: René Kuhn <[email protected]>
jgraichen
requested changes
Dec 12, 2024
plugin.go
Outdated
| @@ -385,9 +385,9 @@ func (d plugin) getByName(name string) (*volumes.Volume, error) { | |||
| return volume, err | |||
| } | |||
|
|
|||
| func (d plugin) detachVolume(ctx context.Context, vol *volumes.Volume) (*volumes.Volume, error) { | |||
There was a problem hiding this comment.
How about we keep context.Context as an argument to all internal functions, and pass a single context.TODO() from the main functions?
func (d plugin) Mount(r *volume.MountRequest) (*volume.MountResponse, error) {
ctx := context.TODO()
...
if vol, err = d.waitOnVolumeState(ctx, vol, "available"); err != nil {
...
if vol, err = d.detachVolume(ctx, vol); err != nil {
...
This way, we would be able to e.g. pass a cancelable context later if needed (https://pkg.go.dev/context).
There was a problem hiding this comment.
That's a good idea. Should the same instance of context.TODO() be passed to the other functions using their own instance of it at the moment?
Like in this line, for example:
https://github.com/SLH335/docker-plugin-cinder/blob/93cab39892abd699b64a6b3f67d38d5be2bed382/plugin.go#L192
There was a problem hiding this comment.
Yes, that sounds about right! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the functions
detachVolumeandwaitOnVolumeState. These functions currently return an error due to a nil logger context being passed to the network request. This PR changes these functions to use a new empty context instead.