Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Certificates preview display signer information regardless of whether they have a signature image or not #36293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

efortish
Copy link

Render certificate preview with signer data regardless of whether it has a signature image or not

Description

This PR modifies the _accomplishment-rendering.html template to ensure that the information of signatories is displayed even if there is no signature image available. The image will only be rendered if the signature_image_path is present, preventing the display of a placeholder image when the signature image is missing.

Changes Made

  • Updated the _accomplishment-rendering.html template to conditionally render the signature image.
  • Ensured that the name, title, and organization of the signatory are always displayed.

Objective

The objective of this change is to improve the user experience by ensuring that the information of signatories is always visible, even if the signature image is not available. This prevents the display of a placeholder image and ensures that the certificate looks complete and professional.

Achievements

  • Improved Visibility: Signatory information is always displayed, regardless of the presence of a signature image.
  • Enhanced User Experience: Prevents the display of a placeholder image, ensuring a cleaner and more professional appearance of the certificate.

Testing

  • Verified that the signatory information is displayed correctly even if the signature image is not available.

image

image

Related Issues

  • Issue #1370: Org logo and signatory info don't display without optional signature images

Additional Notes

  • Ensure that the changes do not affect other parts of the certificate rendering process.

@openedx-webhooks
Copy link

Thanks for the pull request, @efortish!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 24, 2025
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 24, 2025
@e0d
Copy link
Contributor

e0d commented Feb 25, 2025

@efortish if you should be covered under the eduNEXT organization CLA, can you have Juan or Felipe request that you are added.

@e0d
Copy link
Contributor

e0d commented Feb 25, 2025

Ah, looks like the CLA is all set. I'll invited you to the triage team which will allow tests to run automatically for you in the future.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 25, 2025
@efortish
Copy link
Author

Thank you so much @e0d !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants