-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove duplicate imports of js files in instructor dashboard pages #36289
base: master
Are you sure you want to change the base?
fix: Remove duplicate imports of js files in instructor dashboard pages #36289
Conversation
Thanks for the pull request, @rehmansheikh222! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@rehmansheikh222 should you be covered under the Arbisoft entity CLA? If so, please ask your HR department to reach out and add you so the CLA check will pass. |
Yes, I will be covered under the Arbisoft entity CLA and they have added me under CLA. It may take some time to reflect on github. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I was working on enabling the dark theme in the Instructor Dashboard using Tutor Indigo, which adds the dark theme file to the application JavaScript pipeline. However, the dark theme toggle wasn’t working, no matter how many times I clicked it. After digging into the issue, I found that the event listener for the theme toggle was being added twice, causing it to do nothing.
The reason for this double event listener was that the Instructor Dashboard was importing the application JavaScript pipeline twice. Here’s how it happened: The Instructor Dashboard inherits from main.html, which includes the application pipeline. On top of that, the Instructor Dashboard itself explicitly imports the application pipeline again. This led to every JavaScript file in the application pipeline, including the dark theme file, being loaded twice.
To fix this, I removed the redundant import of the application pipeline from the Instructor Dashboard. Now, the application pipeline is loaded only once, ensuring that event listeners are registered correctly. This change fixed the dark theme toggle issue and prevents similar problems from happening in the future.