-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow LTI blocks to be loaded in a Library v2 context [FC-0076] #36265
base: master
Are you sure you want to change the base?
fix: allow LTI blocks to be loaded in a Library v2 context [FC-0076] #36265
Conversation
Thanks for the pull request, @pomegranited! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
71997fc
to
1b5def8
Compare
so that they fit better in the preview sidebar and expanded iframe views
and generalize it so it can be used by LTI and WordCloud blocks
6d2bafc
to
57ce36c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your work, @pomegranited!
This is working great!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
Description
Fixes errors thrown when previewing/editing (built-in) LTI blocks in a Libraries v2 context.
These fixes allow Library Authors to store LTI blocks in their content libraries.
Supporting information
Part of: openedx/frontend-app-authoring#1514
Private-ref: FAL-4032
Testing instructions
To verify the issues fixed here:
lti
andword_cloud
are in the list ofLIBRARY_SUPPORTED_BLOCKS
configured for your Authoring MFE.tutor dev do importdemocourse
To test this fix:
See Other information below for notes on the authentication errors shown.
Deadline
None
Other information
So for LTI blocks like Codeboard.io where "Open in New Page" is set to False, you will see an error like this:

And for LTI blocks like the Jupyter example where "Open in New Page" is set to True, you won't see the authentication issue until you click "View resource in a new window"

2. Some of the buttons in the library block editors for LTI + Word Cloud do not work. Fixing this will have to come in another PR -- I was unable to work out why these buttons aren't hooked up with backbone on load.